[Bleeding] Audit of onPlace methods, Moved to postPlace as appropriate.

Closes BUKKIT-89

src/main/java/net/minecraft/server/BlockTorch.java

@@ -0,0 +1,157 @@
+package net.minecraft.server;
+
+import java.util.Random;
+
+public class BlockTorch extends Block {
+
+    protected BlockTorch(int i, int j) {
+        super(i, j, Material.ORIENTABLE);
+        this.a(true);
+    }
+
+    public AxisAlignedBB e(World world, int i, int j, int k) {
+        return null;
+    }
+
+    public boolean a() {
+        return false;
+    }
+
+    public boolean b() {
+        return false;
+    }
+
+    public int c() {
+        return 2;
+    }
+
+    private boolean g(World world, int i, int j, int k) {
+        if (world.b(i, j, k, true)) {
+            return true;
+        } else {
+            int l = world.getTypeId(i, j, k);
+
+            return l == Block.FENCE.id || l == Block.NETHER_FENCE.id;
+        }
+    }
+
+    public boolean canPlace(World world, int i, int j, int k) {
+        return world.b(i - 1, j, k, true) ? true : (world.b(i + 1, j, k, true) ? true : (world.b(i, j, k - 1, true) ? true : (world.b(i, j, k + 1, true) ? true : this.g(world, i, j - 1, k))));
+    }
+
+    public void postPlace(World world, int i, int j, int k, int l) {
+        int i1 = world.getData(i, j, k);
+
+        if (l == 1 && this.g(world, i, j - 1, k)) {
+            i1 = 5;
+        }
+
+        if (l == 2 && world.b(i, j, k + 1, true)) {
+            i1 = 4;
+        }
+
+        if (l == 3 && world.b(i, j, k - 1, true)) {
+            i1 = 3;
+        }
+
+        if (l == 4 && world.b(i + 1, j, k, true)) {
+            i1 = 2;
+        }
+
+        if (l == 5 && world.b(i - 1, j, k, true)) {
+            i1 = 1;
+        }
+
+        world.setData(i, j, k, i1);
+    }
+
+    public void a(World world, int i, int j, int k, Random random) {
+        super.a(world, i, j, k, random);
+        if (world.getData(i, j, k) == 0) {
+            this.onPlace(world, i, j, k);
+        }
+    }
+
+    public void onPlace(World world, int i, int j, int k) {
+        /* // CraftBukkit start - we do this, correctly, in postPlace
+        if (world.b(i - 1, j, k, true)) {
+            world.setData(i, j, k, 1);
+        } else if (world.b(i + 1, j, k, true)) {
+            world.setData(i, j, k, 2);
+        } else if (world.b(i, j, k - 1, true)) {
+            world.setData(i, j, k, 3);
+        } else if (world.b(i, j, k + 1, true)) {
+            world.setData(i, j, k, 4);
+        } else if (this.g(world, i, j - 1, k)) {
+            world.setData(i, j, k, 5);
+        }
+
+        this.h(world, i, j, k);
+        */ // CraftBukkit end
+    }
+
+    public void doPhysics(World world, int i, int j, int k, int l) {
+        if (this.h(world, i, j, k)) {
+            int i1 = world.getData(i, j, k);
+            boolean flag = false;
+
+            if (!world.b(i - 1, j, k, true) && i1 == 1) {
+                flag = true;
+            }
+
+            if (!world.b(i + 1, j, k, true) && i1 == 2) {
+                flag = true;
+            }
+
+            if (!world.b(i, j, k - 1, true) && i1 == 3) {
+                flag = true;
+            }
+
+            if (!world.b(i, j, k + 1, true) && i1 == 4) {
+                flag = true;
+            }
+
+            if (!this.g(world, i, j - 1, k) && i1 == 5) {
+                flag = true;
+            }
+
+            if (flag) {
+                this.b(world, i, j, k, world.getData(i, j, k), 0);
+                world.setTypeId(i, j, k, 0);
+            }
+        }
+    }
+
+    private boolean h(World world, int i, int j, int k) {
+        if (!this.canPlace(world, i, j, k)) {
+            if (world.getTypeId(i, j, k) == this.id) {
+                this.b(world, i, j, k, world.getData(i, j, k), 0);
+                world.setTypeId(i, j, k, 0);
+            }
+
+            return false;
+        } else {
+            return true;
+        }
+    }
+
+    public MovingObjectPosition a(World world, int i, int j, int k, Vec3D vec3d, Vec3D vec3d1) {
+        int l = world.getData(i, j, k) & 7;
+        float f = 0.15F;
+
+        if (l == 1) {
+            this.a(0.0F, 0.2F, 0.5F - f, f * 2.0F, 0.8F, 0.5F + f);
+        } else if (l == 2) {
+            this.a(1.0F - f * 2.0F, 0.2F, 0.5F - f, 1.0F, 0.8F, 0.5F + f);
+        } else if (l == 3) {
+            this.a(0.5F - f, 0.2F, 0.0F, 0.5F + f, 0.8F, f * 2.0F);
+        } else if (l == 4) {
+            this.a(0.5F - f, 0.2F, 1.0F - f * 2.0F, 0.5F + f, 0.8F, 1.0F);
+        } else {
+            f = 0.1F;
+            this.a(0.5F - f, 0.0F, 0.5F - f, 0.5F + f, 0.6F, 0.5F + f);
+        }
+
+        return super.a(world, i, j, k, vec3d, vec3d1);
+    }
+}